Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links to 'references' do not work #1378

Closed
snden opened this issue Feb 26, 2023 · 2 comments · Fixed by #1379
Closed

links to 'references' do not work #1378

snden opened this issue Feb 26, 2023 · 2 comments · Fixed by #1379
Assignees
Labels
bug Issue: Something isn't working
Milestone

Comments

@snden
Copy link

snden commented Feb 26, 2023

In versions 2.x, the links in the browser section - at the bottom - 'references' do not work. When I click on a reference, nothing happens, the referenced chapter does not appear. In version 1.6.6 this still works. I've been running Novelwriter from appimage since version 2.x.
novelWriter - Gutta Cavat Lapidem_001

@snden snden added the bug Issue: Something isn't working label Feb 26, 2023
@vkbo
Copy link
Owner

vkbo commented Feb 26, 2023

Confirmed. This is due to a change in how the titles are indexed, which changed in 2.0. However, this particular feature still tests that the clicked link is on the old format before opening the document, which is of course no longer the case so it does nothing.

Apparently this is not covered by tests. This is a very old part of the code, and some bits are still not covered. A path needs to both fix the bug and add test coverage.

@vkbo vkbo self-assigned this Feb 26, 2023
@vkbo vkbo added this to the Release 2.0.6 milestone Feb 26, 2023
@vkbo
Copy link
Owner

vkbo commented Feb 26, 2023

I will try to get out a fix on this, and the other two issues in the 2.0.6 milestone, later tonight.

vkbo added a commit that referenced this issue Feb 26, 2023
@vkbo vkbo linked a pull request Feb 26, 2023 that will close this issue
6 tasks
@vkbo vkbo closed this as completed Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants