Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format > Align left misplaces the text cursor when applying format to a new blank line #1350

Closed
tmarplatt opened this issue Feb 8, 2023 · 1 comment · Fixed by #1354
Closed

Format > Align left misplaces the text cursor when applying format to a new blank line #1350

tmarplatt opened this issue Feb 8, 2023 · 1 comment · Fixed by #1354
Assignees
@vkbo
Labels
bug Issue: Something isn't working editor Component: Editor usability Issue: Could do with some improvement
Milestone
Release 2.0.5

Comments

@tmarplatt
Copy link
Contributor

The problem

Left-aligning a new blank line (it must not be an existing one, or the issue may not reproduce) inserts the requested alignment markup after a linebreak (see #1349 as I believe this is related), but leaves the text cursor sitting at the line before.

How to reproduce

  1. In the editor, enter a new line.
  2. Hit Ctrl+5.
  3. novelWriter will have added a line break and the left-alignment markup, but the text cursor will remain at the previous line.

The expectation

Left-aligning a blank paragraph should insert the markup in the same line where the text cursor is currently located.
@tmarplatt tmarplatt added the bug Issue: Something isn't working label Feb 8, 2023
@vkbo vkbo self-assigned this Feb 8, 2023
@vkbo vkbo added this to the Release 2.0.5 milestone Feb 8, 2023
@vkbo vkbo mentioned this issue Feb 8, 2023
Closed
@vkbo
Copy link
Owner

vkbo commented Feb 8, 2023

Same cause as described here: #1349 (comment)

@vkbo vkbo added editor Component: Editor usability Issue: Could do with some improvement labels Feb 8, 2023
vkbo added a commit that referenced this issue Feb 10, 2023
@vkbo
Only insert line break for block formats if the block already has text (
5b20061 
#1349, #1350)
@vkbo vkbo mentioned this issue Feb 10, 2023
Merged
6 tasks
@vkbo vkbo linked a pull request Feb 10, 2023 that will close this issue
Fix block formatting issues #1354
Merged
6 tasks
@vkbo vkbo closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkbo vkbo

Labels
bug Issue: Something isn't working editor Component: Editor usability Issue: Could do with some improvement
Projects
None yet
Milestone
Release 2.0.5
Development

Successfully merging a pull request may close this issue.

Fix block formatting issues vkbo/novelWriter
2 participants
@vkbo @tmarplatt