Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-app] Unify steps for cookie management #5637

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valfirst
Copy link
Collaborator

@valfirst valfirst commented Jan 2, 2025

No description provided.

@valfirst valfirst requested a review from a team as a code owner January 2, 2025 20:17
@valfirst valfirst force-pushed the web-app-unify-steps-for-cookie-management branch from 17019ba to dacd0c2 Compare January 2, 2025 20:21
@valfirst valfirst marked this pull request as draft January 2, 2025 20:21
Copy link

github-actions bot commented Jan 2, 2025

Qodana for JVM

5 new problems were found

Inspection name Severity Problems
Incorrect constructor injection in XML Spring bean 🔴 Failure 5

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@@ -18,6 +18,8 @@
<property name="uriToIgnoreRegex" value="${resource-checker.uri-to-ignore-regex}" />
</bean>

<bean id="browserAndHttpContextIntegrationSteps" class="org.vividus.integration.steps.BrowserAndHttpContextIntegrationSteps" />

Check failure

Code scanning / QDJVM

Incorrect constructor injection in XML Spring bean Error

No matching constructor found in class 'BrowserAndHttpContextIntegrationSteps'#treeend |-------------------------------------------------|---|-----------|
| BrowserAndHttpContextIntegrationSteps(...): | | Bean: |
| CookieManager<?> cookieManager | | ??? |
| CookieStoreProvider cookieStoreProvider | | ??? |
| HttpTestContext httpTestContext | | ??? |
| NavigateActions navigateActions | | ??? |
| AttachmentPublisher attachmentPublisher | | ??? |
@@ -68,7 +68,7 @@
<property name="stickyHeaderSizePercentage" value="${web-application.sticky-header-size-percentage}" />
</bean>
<bean id="mouseActions" class="org.vividus.ui.web.action.MouseActions" />
<bean id="navigateActions" class="org.vividus.ui.web.action.NavigateActions" />
<bean id="navigateActions" class="org.vividus.ui.web.action.SeleniumNavigateActions" />

Check failure

Code scanning / QDJVM

Incorrect constructor injection in XML Spring bean Error

No matching constructor found in class 'SeleniumNavigateActions'#treeend |----------------------------------------|---|----------------------------------------------------|
| SeleniumNavigateActions(...): | | Bean: |
| IWebDriverProvider webDriverProvider | | ??? |
| WebJavascriptActions javascriptActions | | Autowired: javascriptActions(WebJavascriptActions) |
| IWebWaitActions waitActions | | Autowired: null(WebWaitActions) |
| ISoftAssert softAssert | | ??? |
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (5c9fc13) to head (dacd0c2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5637   +/-   ##
=========================================
  Coverage     97.70%   97.70%           
+ Complexity     7134     7133    -1     
=========================================
  Files           989      988    -1     
  Lines         20683    20684    +1     
  Branches       1353     1354    +1     
=========================================
+ Hits          20209    20210    +1     
  Misses          363      363           
  Partials        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant