-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web-app] Unify steps for cookie management #5637
base: master
Are you sure you want to change the base?
Conversation
17019ba
to
dacd0c2
Compare
Qodana for JVM5 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
@@ -18,6 +18,8 @@ | |||
<property name="uriToIgnoreRegex" value="${resource-checker.uri-to-ignore-regex}" /> | |||
</bean> | |||
|
|||
<bean id="browserAndHttpContextIntegrationSteps" class="org.vividus.integration.steps.BrowserAndHttpContextIntegrationSteps" /> |
Check failure
Code scanning / QDJVM
Incorrect constructor injection in XML Spring bean Error
| BrowserAndHttpContextIntegrationSteps(...): | | Bean: |
| CookieManager<?> cookieManager | | ??? |
| CookieStoreProvider cookieStoreProvider | | ??? |
| HttpTestContext httpTestContext | | ??? |
| NavigateActions navigateActions | | ??? |
| AttachmentPublisher attachmentPublisher | | ??? |
@@ -68,7 +68,7 @@ | |||
<property name="stickyHeaderSizePercentage" value="${web-application.sticky-header-size-percentage}" /> | |||
</bean> | |||
<bean id="mouseActions" class="org.vividus.ui.web.action.MouseActions" /> | |||
<bean id="navigateActions" class="org.vividus.ui.web.action.NavigateActions" /> | |||
<bean id="navigateActions" class="org.vividus.ui.web.action.SeleniumNavigateActions" /> |
Check failure
Code scanning / QDJVM
Incorrect constructor injection in XML Spring bean Error
| SeleniumNavigateActions(...): | | Bean: |
| IWebDriverProvider webDriverProvider | | ??? |
| WebJavascriptActions javascriptActions | | Autowired: javascriptActions(WebJavascriptActions) |
| IWebWaitActions waitActions | | Autowired: null(WebWaitActions) |
| ISoftAssert softAssert | | ??? |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5637 +/- ##
=========================================
Coverage 97.70% 97.70%
+ Complexity 7134 7133 -1
=========================================
Files 989 988 -1
Lines 20683 20684 +1
Branches 1353 1354 +1
=========================================
+ Hits 20209 20210 +1
Misses 363 363
Partials 111 111 ☔ View full report in Codecov by Sentry. |
No description provided.