Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render DialogContent around DataGrid #3375

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

jamesricky
Copy link
Contributor

Description

DataGrid should not have a spacing around it when rendered inside a Dialog according to the Comet design guidelines.

Acceptance criteria

Screenshots/screencasts

Before After
Grid in Dialog with DialogContent Grid in Dialog without DialogContent

Further information

@jamesricky jamesricky self-assigned this Feb 7, 2025
@johnnyomair johnnyomair merged commit 59c614c into main Feb 10, 2025
11 checks passed
@johnnyomair johnnyomair deleted the remove-dialog-content-when-rendering-a-datagrid branch February 10, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants