Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usage of composite-block field-helpers #3155

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Improve usage of composite-block field-helpers #3155

merged 3 commits into from
Jan 20, 2025

Conversation

jamesricky
Copy link
Contributor

Acceptance criteria

Open TODOs/questions

  • Add changeset

@jamesricky jamesricky self-assigned this Jan 15, 2025
@jamesricky jamesricky force-pushed the simplify-usage-of-composite-block-helpers branch from 403952b to 78699f1 Compare January 15, 2025 12:25
@jamesricky jamesricky changed the title Allow setting props directly instead of nesting them within fieldProps Improve usage of composite-block field-helpers Jan 15, 2025
This was referenced Jan 15, 2025
Merged
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

johnnyomair
johnnyomair reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update this in Starter as well once this has been merged and published.

.changeset/tender-socks-trade.md Show resolved Hide resolved
@johnnyomair johnnyomair added the needs-starter-pr Change in Demo that needs to be changed in Starter as well. label Jan 20, 2025
@johnnyomair johnnyomair merged commit 86479e7 into main Jan 20, 2025
13 checks passed
@johnnyomair johnnyomair deleted the simplify-usage-of-composite-block-helpers branch January 20, 2025 10:44
@jamesricky
Copy link
Contributor Author

We need to update this in Starter as well once this has been merged and published.

I created a task: https://vivid-planet.atlassian.net/browse/COM-1567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@jamesricky jamesricky

Labels
needs-starter-pr Change in Demo that needs to be changed in Starter as well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesricky @johnnyomair