Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SVG validation #2968

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Improve SVG validation #2968

merged 3 commits into from
Jan 21, 2025

Conversation

thomasdax98
Copy link
Member

@thomasdax98 thomasdax98 commented Dec 19, 2024 •
edited
Loading

Description

Improve SVG validation

Following tags are banned in SVGs:

  • script
  • [new] foreignObject
  • [new] use
  • [new] image
  • [new] animate
  • [new] animateMotion
  • [new] animateTransform
  • [new] set

Following attributes are banned:

  • Event handlers (onload, onclick, ...)
  • [new] href and xlink:href (if the value starts with http://, https:// or javascript:)

Acceptance criteria

Screenshots/screencasts

Bildschirmfoto 2024-12-19 um 15 59 18

Further information

@thomasdax98 thomasdax98 marked this pull request as ready for review December 19, 2024 15:20
@auto-assign auto-assign bot requested a review from johnnyomair December 19, 2024 15:20
@thomasdax98 thomasdax98 force-pushed the improve-svg-validation branch from de194d3 to 1aa6282 Compare December 20, 2024 08:12
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 20, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@johnnyomair johnnyomair merged commit f49370a into main Jan 21, 2025
11 checks passed
@johnnyomair johnnyomair deleted the improve-svg-validation branch January 21, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@thomasdax98 thomasdax98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasdax98 @johnnyomair