Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update script for renaming menu components #45

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Dec 24, 2024

Update naming of admin components:

  • Menu → MainNavigation
  • MenuItem → MainNavigationItem
  • MenuCollapsibleItem → MainNavigationCollapsibleItem
  • MenuContext → MainNavigationContext
  • MenuItemAnchorLink → MainNavigationAnchorLinkItem
  • MenuItemGroup → MainNavigationItemGroup
  • MenuItemRouterLink → MainNavigationRouterLinkItem

Example update

Tested in a random comet 7 project:

  • Components imported from @comet/admin will be updated.
  • Components imported from @mui-material stay as they are:
Screenshot 2024-12-30 at 10 49 46

vivid-planet/comet#2996

https://vivid-planet.atlassian.net/browse/COM-1480

@juliawegmayr juliawegmayr force-pushed the rename-menu-components branch from 38f0a45 to 20a6aeb Compare December 30, 2024 09:29
@juliawegmayr juliawegmayr marked this pull request as ready for review December 30, 2024 09:52
@johnnyomair johnnyomair changed the title add update script for renaming menu components Add update script for renaming menu components Jan 9, 2025
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review this again once vivid-planet/comet#2996 has been merged.

@johnnyomair johnnyomair marked this pull request as draft January 21, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants