Make EChange generic over its content type
#594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanWittler
force-pushed
the
change-generic
branch
from
170d0a3 to
f4bbf35
Compare
JanWittler
force-pushed
the
change-generic
branch
from
a8f841e to
9b88e9e
Compare
TomWerm
approved these changes
Jul 10, 2023
|
@vitruv-tools/maintainers Due to the new type safety for changes, it becomes apparent that the tool adapters are not working anymore. Besides probably many flaws there, right now they don't compile anymore because there is no functionality to transform from the recorded I suggest to make the Tool Adapters legacy. I don't think it is worth it to hack some UUID resolver into the adapters to make it work. The proper way of fixing them would be migrate to the View-API but that would require rewriting most of the code anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts to vitruv-tools/Vitruv-Change#59