Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TestViewFactory to Java #573

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

JanWittler
Copy link
Contributor

Refactors the TestViewFactory to Java as otherwise it cannot be used by other Java classes.
The code is pretty much a duplicate of the Xtend code but we might discuss whether we want to explicitly throw exceptions (as it is implemented right now) or reuse the sneaky throw mechanics of Xtend (i.e. the Exception is not declared and thus needs not to be catched explicitly). I selected the former approach to have the Exception semantics explicit but one might argue that, as it is only for testing purposes, not having to catch the exceptions might make the test code easier to write. In the end, the current design results in any view-based test method declaring a throws Exception in its signature.

@JanWittler JanWittler requested a review from TomWerm as a code owner November 22, 2022 08:26
@TomWerm TomWerm merged commit 2b0e715 into main Nov 22, 2022
@TomWerm TomWerm deleted the refactor-view-factory-to-java branch November 22, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants