Support change propagation mode customization in view-based tests #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in our UML <-> Java tests, we run uni- and bidirectional tests by calling
setupTransformationDirectionbefore each tests. By default, unidirectional tests are executed. Additionally, each test class has a subclass where the method is overridden to configure bidirectional tests.In this implementation however is a mistake such that the bidirectional configuration happens only accidentally. More specifically, when overriding a method without again specifying the JUnit annotations (here
@BeforeEach), the annotation is lost and thus the method is not executed. In the UML <-> Java test cases, this results in thesetupTransformationDirectionmethod not called and thus the default change propagation mode being used which is accidentally theTRANSITIVE_CYCLICmode when want.To prevent such accidental configurations, I added an endpoint which can be safely overridden without having to care for JUnit annotations.