Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Vitruv-Change cleanup #570

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Adapt to Vitruv-Change cleanup #570

merged 3 commits into from
Oct 26, 2022

Conversation

JanWittler
Copy link
Contributor

@JanWittler JanWittler commented Oct 26, 2022

Adapts the framework to the interface changes introduced in vitruv-tools/Vitruv-Change#46 and rewrites the affected classes in Java.

As the Java rewrite makes the differences hard to identify, the following changed:

  • Create a local change propagator instance in VirtualModelImpl#propagateChange instead of having one global
    • To support this, the following three instance attributes were added:
private final ChangePropagationSpecificationProvider changePropagationSpecificationProvider;
private final InternalUserInteractor userInteractor;
private ChangePropagationMode changePropagationMode = ChangePropagationMode.TRANSITIVE_CYCLIC;

@JanWittler JanWittler requested a review from tsaglam October 26, 2022 12:54
@JanWittler JanWittler requested a review from TomWerm as a code owner October 26, 2022 12:54
@JanWittler JanWittler force-pushed the prepare-vsum-versioning branch from a02b8c2 to 0411173 Compare October 26, 2022 13:09
@JanWittler JanWittler merged commit 81907ae into main Oct 26, 2022
@JanWittler JanWittler deleted the prepare-vsum-versioning branch October 26, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants