Replace UUIDs with EObjects in Correspondence Model #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
changed the title
HeikoKlare
force-pushed
the
correspondence-model-eobjects
branch
from
a02027a to
20a7aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the UUID-based correspondences with
EObject-based ones. The indirection across UUIDs is unnecessary and introduced unnecessarily complicated logic both within theCorrespondenceModelas well as within theUuidGeneratorAndResovlerImpl. In addition, this simplification should significantly easy debugging, because the correspondences (including their persistence) than reference objects (or their URIs, respectively) instead of cryctic UUIDs.In detail:
EObjectsinCorrespondences, such that the correspondence model becomes completely independent from UUIDsUuidGeneratorAndResolverImplwhich was only necessary for correspondences created for objects that were not yet added to models.CorrespondenceModelUtilsby removing unnecessary methods.