Add GitHub Action for Validation Against Applications #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
applications-validation
branch
13 times, most recently
from
dcf4073 to
28a6540
Compare
HeikoKlare
force-pushed
the
applications-validation
branch
from
28a6540 to
5537c81
Compare
jGleitz
reviewed
Mar 3, 2021
| with: | ||
| working-directory: ./framework | ||
| run: > | ||
| ./mvnw -B clean verify |
There was a problem hiding this comment.
I’d propose to only run package here and set the appropriate options to skip all tests. This will speed up the job and tests will be run by the other job anyway.
There was a problem hiding this comment.
Plus, it might be interesting to see whether changes are compatible with the applications even if the unit tests still fail.
There was a problem hiding this comment.
Ah, that's a great idea, thanks! I already merged to use the validation for further PRs as soon as possible, but I will of course provide an update that implements that improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub action that validates the CBS applications against the framework changes propsed in a pull request. See the discussion in #427.
It uses the
masterbranches of the CBS domains and applications or, if existing, the branches with the same name as the one of the pull request. This will currently only work if the branch is present in the repository of thevitruv-toolsorganization and not in a fork.Closes #427.