-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PcmUmlClassTests View-Based #274
Conversation
- Open: fix tests to handle primitive types correctly (currently disabled) - Open: fix MediaStoreRepositoryCreationTest - LegacyPcmUmlClassApplicationTest and Helper are still required in transitive change tests
...pcmumlclass.tests/src/tools/vitruv/applications/pcmumlclass/tests/SignatureConceptTest.xtend
Outdated
Show resolved
Hide resolved
...pcmumlclass.tests/src/tools/vitruv/applications/pcmumlclass/tests/SignatureConceptTest.xtend
Show resolved
Hide resolved
...ns.pcmumlclass.tests/src/tools/vitruv/applications/pcmumlclass/tests/SystemConceptTest.xtend
Outdated
Show resolved
Hide resolved
...tests/src/tools/vitruv/applications/pcmumlclass/tests/MediaStoreRepositoryCreationTest.xtend
Outdated
Show resolved
Hide resolved
...tests/src/tools/vitruv/applications/pcmumlclass/tests/MediaStoreRepositoryCreationTest.xtend
Outdated
Show resolved
Hide resolved
...tests/src/tools/vitruv/applications/pcmumlclass/tests/MediaStoreRepositoryCreationTest.xtend
Outdated
Show resolved
Hide resolved
...tests/src/tools/vitruv/applications/pcmumlclass/tests/MediaStoreRepositoryCreationTest.xtend
Outdated
Show resolved
Hide resolved
...tests/src/tools/vitruv/applications/pcmumlclass/tests/MediaStoreRepositoryCreationTest.xtend
Outdated
Show resolved
Hide resolved
...tests/src/tools/vitruv/applications/pcmumlclass/tests/MediaStoreRepositoryCreationTest.xtend
Outdated
Show resolved
Hide resolved
Thank you very much for your contribution. I added some minor comments which we should discuss. For this PR to be merged, I think we have to first fix the primitive type issues. I will try to free some time to work on that. |
…ryCreation - simplification: removal of roundtrip tests and stepwise insertion of the UML-Metamodel reasons for this step are: - tests have been disabled for a long time - stepwise insertion isn't the target state - stepwise insertion heavily depends on details of the reaction which results in high complexity and high maintenance effort
…-CaseStudies into pcmumlclass-update
Some test cases only work with a adaption of the Adaption in the
The |
- PcmUmlClassHelper.mapPrimitiveTypes returns now only one PrimitiveType instead of a set of matching Types. UML Primitive Types are used if available, the JAVA PrimitiveTypes are only used if no matching type is existent - goal: make clear which PrimitiveType is used by the reaction (and avoid indeterminism) - adapted some tests
There is a 1:n relation between PCM and UML PrimitiveDataTypes. The correspondences of the prefered mapping from PCM to UML is stored with tag DATATYPE__TYPE. In case a not prefered UML Datatype is used anyway in the UML model, the tag DATATYPE__TYPE__ALTERNATIVE stores also correspondences between not prefered UML datatypes and corresponding PCM datatypes. - adapted productive and test code to handle this mapping
Get rid of tests that are based on LegacyPcmUmlClassApplicationTest and use instead PcmUmlClassApplicationTest which is a ViewBasedVitruvApplicationTest