Refactors JavaEditor -> PCM tests to view-based API #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the Java Editor to PCM tests to use the view-based API.
Currently, the tests are indeterministically failing due to some timing issues (same problems as in legacy tests). The underlying problem is that the asynchronous calls of Eclipse and Eclipse JDT do not always notify the
IProgressMonitorabout their completion and thus the the underlying file state may not be correctly updated when trying to modify them or derive and propagate changes. However, with enough attempts, each test each is already working.