memo v2: thunk-based bass.lock #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not amazing, but better than panicking
bass.lock now stores not only the results for a function, but everything needed to re-run it if desired. instead of a category, each input/output is associated to a Bass thunk to (load) and the binding of the function to call. this should be much more airtight. along the way, replace (memo) with a native bass implementation in terms of two more low-level bindings (which I might move to the internal scope).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of setting arbitrary categories in a global namespace,
bass.locknow stores results associated to a Bass thunk + function binding.this paves the way for adding a
bass --bumpcommand for bumping dependencies, by re-running the embedded thunks and updating the output values.it's also much more precise.
the gap I have yet to solve is when to remove/garbage collect stale entries. but that was a problem before too.