Download favorites as JSON #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After opening this PR I now realize there is a related one for downloading one's favorites. Mine is only about fetching the metadata as JSON. @vitiko98 it might be worth considering both PRs in parallel, wdyt? |
|
I realize it is actually a bad idea to overload the qobuz-dl cli with metadata handling. This might be better done by a separate script instead. I will reopen a new PR limited to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in
qopy.pythat prevented fetching favorite tracks and artists (the API call does not take thetypeparameter into account and always fetches the favorite albums instead).It also adds a method in the Qobuz core api to download all favorites as a JSON file, and exposes it in the CLI via the
favscommand. This is probably not very helpful for normal usage but it can be useful for post-processing or integration with other tools, or just to keep a local archive of one's favorites for reference.