-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add perfStats to json reporter #933
Conversation
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 7a45ae5 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/622db5797c19900008e19fa3 😎 Browse the preview: https://deploy-preview-933--vitest-dev.netlify.app |
What about |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any reason we're not using performance.now()? My test fixtures are too fast and Date.now() is giving me "0" in the duration of my tasks. |
@JessicaSachs duration is recorded somewhere else, which is not related to this PR |
That's fine, I meant in general. @sheremet-va and I spoke on Discord and he asked me to make an issue to swap the recording of stats throughout Vitest from |
Add the missing field
perfStats
to JSON TestResult compared to Jest test result type.