Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tinyglobby instead of fast-glob in Vitest #7504

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

benmccann
Copy link
Contributor

This reverts commit 70baaaa.

Description

Discussed here: #6688 (comment)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5df1978
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67b2886709208c0008bcc668
😎 Deploy Preview https://deploy-preview-7504--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it Storybook whose tests failed after this change previously, @sheremet-va? They are not in the ecosystem-ci so we'll need preview release for them to try.

Copy link

pkg-pr-new bot commented Feb 17, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7504

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7504

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7504

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7504

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7504

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7504

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7504

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7504

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7504

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7504

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7504

vite-node

npm i https://pkg.pr.new/vite-node@7504

vitest

npm i https://pkg.pr.new/vitest@7504

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7504

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7504

commit: 5df1978

@AriPerkkio
Copy link
Member

cc. @JReinhold

@JReinhold
Copy link

Looks good in Storybook, everything works!

To be safe, I also tested with Vitest 2.1.0 (the original tinyglobby migration) and that was still broken, 2.1.3 (the revert) worked as expected, and so did this PR version.

For full context, in Storybook's CI we have a lot of stories/tests symlinked into ecosystem directories, and they wouldn't get picked up by the faulty versions of Vitest, but they are with this version.

@AriPerkkio AriPerkkio merged commit b62ac22 into vitest-dev:main Feb 18, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants