Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expect): fix expect().resolves/rejects chain typings #7273

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix(expect): fix expect().resolves/rejects chain typings #7273

merged 2 commits into from
Jan 17, 2025
+14 −3

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 17, 2025 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa marked this pull request as ready for review January 17, 2025 02:41
@sheremet-va sheremet-va merged commit fa41505 into vitest-dev:main Jan 17, 2025
13 checks passed
@hi-ogawa hi-ogawa deleted the fix-expect-resolve-reject-chain-typing branch January 17, 2025 10:22
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 17, 2025
@renovate
chore(deps): update dependency vitest to v3.0.2
1f70268 
##### [v3.0.2](https://github.com/vitest-dev/vitest/releases/tag/v3.0.2)

#####    🐞 Bug Fixes

-   Don't await an empty timeout after every test  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7281 [<samp>(ef1aa)</samp>](vitest-dev/vitest@ef1aa893)
-   **expect**: Fix `expect().resolves/rejects` chain typings  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7273 [<samp>(fa415)</samp>](vitest-dev/vitest@fa415059)

#####     [View changes on GitHub](vitest-dev/vitest@v3.0.1...v3.0.2)
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 17, 2025
@renovate
chore(deps): update dependency vitest to v3.0.2
fced09d 
##### [v3.0.2](https://github.com/vitest-dev/vitest/releases/tag/v3.0.2)

#####    🐞 Bug Fixes

-   Don't await an empty timeout after every test  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7281 [<samp>(ef1aa)</samp>](vitest-dev/vitest@ef1aa893)
-   **expect**: Fix `expect().resolves/rejects` chain typings  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7273 [<samp>(fa415)</samp>](vitest-dev/vitest@fa415059)

#####     [View changes on GitHub](vitest-dev/vitest@v3.0.1...v3.0.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type Promisify<...> has no call signatures
2 participants
@hi-ogawa @sheremet-va