Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest): auto-enable "github-actions" only where users didn't configure reporters #5158

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 9, 2024

Description

Based on the discussion on discord https://discord.com/channels/917386801235247114/1123254125191241868/1205400484530225214, this PR changes github-actions to be auto-enabled only when reporters are not explicitly provided by users.

Though I think it makes sense, this would potentially make it harder for this feature to reach some people. I still kinda want to see this feature to be enabled automatically for any condition on v1.3.0 and later consider tweaking conditions based on users feedback. So, if doing something is really necessary, then I might prefer introducing yet-another variable like VITEST_GITHUB_ACTIONS_REPORTER
#5093 (comment) to allow opting out. What do you think?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 9b45e7f
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65c5e95357a1c20008b94575
😎 Deploy Preview https://deploy-preview-5158--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review February 9, 2024 09:10
@sheremet-va sheremet-va merged commit ef0440c into vitest-dev:main Feb 9, 2024
16 of 19 checks passed
@hi-ogawa hi-ogawa deleted the fix-github-actions-default branch February 9, 2024 10:24
@sheremet-va sheremet-va added this to the 1.3.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants