Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make rule message punctuation more consistent and address some typos #628

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Dec 31, 2024

I noticed a spelling mistake in valid-expect that I'd fixed in eslint-plugin-jest which revealed jest-community/eslint-plugin-jest#1444 has not been ported over, so this mostly does that though also has a few other adjustments.

There's some more improvements that could be made which I don't mind doing (namely around the use of code quotes), but didn't want to do too much without first confirming folks are happy with this kind of "format" 🙂

Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these look good to me! Feel free to open another pr if there is anything else you'd like to improve.

@veritem veritem merged commit 31cae3b into vitest-dev:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants