fix: make rule message punctuation consistent #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
rule: max-expects
rule: max-nested-describe
rule: no-if
rule: valid-title
bug
rule: no-test-return-statement
rule: no-export
rule: no-mocks-import
rule: no-focused-tests
rule: no-identical-title
rule: prefer-spy-on
rule: valid-expect
rule: prefer-expect-resolves
rule: no-standalone-expect
labels
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
## [27.4.2](v27.4.1...v27.4.2) (2023-09-29) ### Bug Fixes * make rule message punctuation consistent ([#1444](#1444)) ([84121ee](84121ee))
|
🎉 This PR is included in version 27.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know ESLint does not have an official stance on the punctuation of rule messages, but in my experience it makes more sense to not end with a full stop because tools either display the rule at the end of their message (e.g. " ()") or have nothing (such as in GitHub Actions annotations, iirc) - either way this at least makes us consistent, and we can invert it later if I turn out to be wrong 🤷