-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for the durability policies #955
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
✔️ Deploy Preview for vitess ready! 🔨 Explore the source changes: 5506cff 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitess/deploys/61f89eb6eba8f300081945d2 😎 Browse the preview: https://deploy-preview-955--vitess.netlify.app/docs/13.0/user-guides/configuration-basic/durability_policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few grammar changes and one link insert suggestion.
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Manan Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving provisionally.
We can merge once feedback has been addressed.
content/en/docs/13.0/user-guides/configuration-advanced/reparenting.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-advanced/reparenting.md
Outdated
Show resolved
Hide resolved
content/en/docs/13.0/user-guides/configuration-basic/durability_policy.md
Outdated
Show resolved
Hide resolved
In case you notice any logs that look like the following, you should create an issue [here](https://github.com/vitessio/vitess/issues) and report it: | ||
``` | ||
invalid configuration - semi-sync should be setup according to durability policies, but enable_semi_sync is not set | ||
``` | ||
``` | ||
invalid configuration - semi-sync should be setup according to durability policies, but the tablet is not primaryEligible | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section still needs to change, right?
First thing people should do is check that their configuration on vtctld matches the config on vttablets, not create an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These logs only happen when someone has specified -durability_policy=semi-sync
and then enableSemiSync isn't set on the tablet or we sent true for semi-sync for a non-primary eligible tablet. These bugs have to be reported, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add one more line asking for the users to verify that the vtctl configuration matches that of vttablet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the requested change. If there is something else that needs change I'll create another PR for it. Merging this PR.
Signed-off-by: Manan Gupta <[email protected]>
… vttablet are in order Signed-off-by: Manan Gupta <[email protected]>
This PR adds the documentation for the durability policies which are part of vtctl, vtctld, vtworker and vtorc. It also documents its usage for logging discrepancies in semi-sync setup as introduced in vitessio/vitess#9533