Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for ers #845

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Update docs for ers #845

merged 1 commit into from
Oct 27, 2021

Conversation

GuptaManan100
Copy link
Member

This PR updates the docs for ERS reflecting the changes in vitessio/vitess#8492

@GuptaManan100
update ers docs
600ed0c 
Signed-off-by: Manan Gupta <[email protected]>
@GuptaManan100 GuptaManan100 added documentation do-not-merge PR contains issues or is dependent on another task labels Oct 14, 2021
@GuptaManan100 GuptaManan100 self-assigned this Oct 14, 2021
@GuptaManan100 GuptaManan100 mentioned this pull request Oct 14, 2021
Closed
@netlify
Copy link

netlify bot commented Oct 14, 2021

✔️ Deploy Preview for vitess ready!

🔨 Explore the source changes: 600ed0c

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitess/deploys/616826fe9f99a00008b94672

😎 Browse the preview: https://deploy-preview-845--vitess.netlify.app

@GuptaManan100
Copy link
Member Author

This PR is not to be merged until release-12 docs have been saved. These changes have not gone into release-12

hallaroo
hallaroo approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@hallaroo hallaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hallaroo
Copy link
Member

This PR is not to be merged until release-12 docs have been saved. These changes have not gone into release-12

I'll update here once I've made the v12 docs PDF.

@hallaroo
Copy link
Member

This PR is not to be merged until release-12 docs have been saved. These changes have not gone into release-12

I'll update here once I've made the v12 docs PDF.

And I've created the v12 pdf of the docs: #852, so whenever you want to merge that shouldn't be blocking any more. Thanks!

@GuptaManan100
Copy link
Member Author

Alright! thankyou very much!

@GuptaManan100 GuptaManan100 merged commit c79090a into vitessio:prod Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallaroo hallaroo hallaroo approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

Assignees

@GuptaManan100 GuptaManan100

Labels
do-not-merge PR contains issues or is dependent on another task documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuptaManan100 @hallaroo