-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change instructions for local install #1220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rameez Sajwani <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
frouioui
added
the
do-not-merge
PR contains issues or is dependent on another task
label
Nov 14, 2022
frouioui
changed the title
Change instructiosn for local install
Change instructions for local install
Nov 15, 2022
frouioui
reviewed
Nov 23, 2022
frouioui
reviewed
Nov 23, 2022
frouioui
reviewed
Nov 23, 2022
frouioui
reviewed
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a few comments that need to be addressed. Not approving this as we have to wait until we do the v15.0.1 release to merge it.
GuptaManan100
previously approved these changes
Nov 24, 2022
Signed-off-by: Rameez Sajwani <[email protected]>
frouioui
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rameez Sajwani [email protected]
There is a a bug in v15.0 where local install fails when it tries to local vtadmin web locally. PR#11683 will fix the issue but we need to reflect these changes in our local install instructions as well. This PR focus on changing the instructions as needed.
Issue#11679