Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dual query with exists clause having system table query in it #9969

Merged
merged 1 commit into from
Mar 27, 2022
Merged

fix: dual query with exists clause having system table query in it #9969

merged 1 commit into from
Mar 27, 2022

Conversation

harshit-gangal
Copy link
Member

Description

This PR adds an empty map if the system table map is uninitialized in route.

Related Issue(s)

Checklist

  • Should this PR be backported? Not sure
  • Tests were added or are not required

Deployment Notes

frouioui
frouioui approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's rebase this PR on main once #9975 is merged.

@harshit-gangal harshit-gangal merged commit f10217f into vitessio:main Mar 27, 2022
@harshit-gangal harshit-gangal deleted the fix-dual-panic branch March 27, 2022 08:59
@frouioui frouioui mentioned this pull request Apr 6, 2022
Closed
24 tasks
@harshit-gangal harshit-gangal mentioned this pull request Apr 7, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vtgate panic - select 1 as one from dual
2 participants
@harshit-gangal @frouioui