fix: allow multiple distinct columns on single shards #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
approved these changes
Mar 22, 2022
systay
added
Type: Enhancement
Signed-off-by: Andres Taylor <[email protected]>
systay
force-pushed
the
multi-distinct-count
branch
from
05c2a95 to
47bb3bc
Compare
This was referenced Apr 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't support multiple distinct columns when aggregating on the vtgate, but there is no reason we should not allow it against single shards.
Related Issue(s)
Fixes #9927
Checklist
No, unless, someone asks for it