Update web/vtctld2 to use node v8.17 #9600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
notfelineit
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node v8.0.0 was giving me all kinds of trouble with
npm install. This PR updates vtctld2 to use node v8.17, the last 8.x LTS version prior to the 8.x EOL in 2020.Having a somewhat-improved version of 8.x will make it easier to upgrade a handful of other vtctld2 dependencies. :)
I also committed changes to package-lock.json that resulted from
npm installafter the version upgrade.I manually validated that the vtctld2 UI still works by running everything locally.
Related Issue(s)
N/A
Checklist
Deployment Notes
There is no action required in this PR for Vitess operators. The UI hosted by the vtctld service uses static files, which I've rebuilt with
make web_buildin this PR.Installing node 8.x is only a requirement for those looking to make changes in the web/vtctld2 codebase.