vtctl ApplySchema: introduce -migration_context flag, synonym to -request_context #9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest_context Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Enhancement
shlomi-noach
requested review from
ajm188,
doeg and
rohit-nayak-ps
as code owners
deepthi
approved these changes
Jan 27, 2022
Good question. I didn't make a plan. We can phase it out at leisure, the variable isn't really any burden, just a couple extra lines of code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today,
vtctl ApplySchemaaccepts a-request_contextflag. We really call it the migration context. InSHOW VITESS_MIGRATIONS ...output it shows asmigration_context.So in this PR,
vtctl ApplySchemanow supports a-migration_contextflag. The two are synonymous so this change is backwards compatible.Also, we've renamed all variables/fields internally from
requestContexttomigrationContextand fromRequestContexttoMigrationContext. Thankfully none of these were in any way exported to JSON or to database by implicit name; we always aliased them properly, so this code change has no effect on existing data, and an upgrade shouldn't break anything.Related Issue(s)
Checklist