Fix for context cancellation in ERS #9503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
…text for the RPCs to run Signed-off-by: Manan Gupta <[email protected]>
deepthi
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error seen in #9502 is traced to the context passed from
reparentReplicasbeing cancelled. We exit out ofEmergencyReparentShardjust as we know that 1 replica succeeded in setting the primary correctly, but the other replicas might still be in flight when ERS ends. So we should not be cancelling their contexts until they are finished or the timeout has expired. This PR fixes this issue.Related Issue(s)
Checklist
Deployment Notes