Gen4Fallback bug fix #9487
Merged
Gen4Fallback bug fix #9487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re we don't mess it up Signed-off-by: Andres Taylor <[email protected]>
… a single shard Signed-off-by: Andres Taylor <[email protected]>
GuptaManan100
approved these changes
Jan 10, 2022
Signed-off-by: Andres Taylor <[email protected]>
Comment on lines
61
to
62
| semTable.ProjectionErr = vterrors.Errorf(vtrpcpb.Code_UNIMPLEMENTED, "unsupported: cross-shard left join and where clause") | ||
| return nil |
There was a problem hiding this comment.
Why revert this change? Isn't it okay to keep it as a ShardedErr?
There was a problem hiding this comment.
Well, we have to either return an error, or build something that adds the predicate to the operator tree. At the moment we don't have a filter operator, so this will be easy to fix post-remove-query-trees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A minor planner fix
When using the
Gen4fallbackplanner, we were not protecting the AST from changes from the Gen4 planner, which lead to the V3 planner getting an already updated AST and failing