-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list support to vindex functions #9426
Add list support to vindex functions #9426
Conversation
8d7797a
to
d848f5a
Compare
Signed-off-by: Matt Lord <[email protected]>
d848f5a
to
fec1266
Compare
"unsupported: where clause for vindex function must be of the form id = <val> or id in(<val>,...) (multiple filters)" | ||
Gen4 plan same as above | ||
|
||
"select keyspace_id from user_index where func(id)" | ||
"unsupported: where clause for vindex function must be of the form id = <val> (not a comparison)" | ||
"unsupported: where clause for vindex function must be of the form id = <val> or id in(<val>,...) (not a comparison)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can stop calling them unsupported, some of them do not seem reasonable queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it in different PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean here. We should call some of them invalid?
Signed-off-by: Matt Lord <[email protected]>
Thanks for the good suggestions, @harshit-gangal ! I've addressed those here: 5af2d18 |
Description
This adds support for vindex function batch lookups using the
IN
SQL operator:For more info about the use case, please see: #9042
Related Issue(s)
Fixes: #9042
Checklist
Deployment Notes