Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relay log position in PRS while choosing the new primary #9270

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

GuptaManan100
Copy link
Member

Description

While choosing the new primary in PRS, we should be using the relay log position, if it is available. This PR makes that change and adds tests for it.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

This PR has been created on top of #9259, and it should be merged after it.

@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management release notes labels Nov 20, 2021
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a nit.
I assume this needs to be rebased once #9259 is merged.

go/vt/vtctl/reparentutil/util.go Outdated Show resolved Hide resolved
@GuptaManan100
Copy link
Member Author

Yes, I'll rebase it once that PR is merged

Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuptaManan100 GuptaManan100 merged commit dddb996 into vitessio:main Nov 30, 2021
@GuptaManan100 GuptaManan100 deleted the prs-use-relay-log branch November 30, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlannedReparent improvements
3 participants