Default buildinfo tablet tags to off

[ajm188]

Signed-off-by: Andrew Mason [email protected]

Description

This is follow-up to #8973 and fixes #9186.

Without changing any of the flags in the local example:

❯ vtctlclient -server ":15999" ListAllTablets
zone1-0000000100 commerce 0 primary localhost:15100 localhost:17100 [] 2021-11-10T20:29:30Z
zone1-0000000101 commerce 0 replica localhost:15101 localhost:17101 [] <null>
zone1-0000000102 commerce 0 rdonly localhost:15102 localhost:17102 [] <null>

Related Issue(s)

Fixes #9186

Checklist

• Should this PR be backported? no
• Tests were added or are not required n/a
• Documentation was added or is not required n/a

Deployment Notes

[mattlord]

Thank you! ❤️

[mattlord]

@ajm188 looks like we need to adjust the new unit test based on what build flags are being ignored on the tablet side: https://github.com/vitessio/vitess/blob/main/go/vt/vttablet/tabletmanager/tm_init_test.go#L513

Example test failure: https://github.com/vitessio/vitess/runs/4170844287?check_suite_focus=true

[ajm188]

oh right! i forgot about that, nice catch

[deepthi]

Is it worth writing a unit test to ensure that when the skip flag is set to "", all the tags do make it into the tablet record?
Otherwise LGTM.