Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add vtctlds view #9143

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Nov 4, 2021

Description

Not much to see here. 🌑

Screen Shot 2021-11-04 at 8 55 34 AM

This is one thing the vtctld2 UI (by definition) can't really do. :)

Related Issue(s)

Other half of #8792.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Anyone running VTAdmin with Consul service discovery (anyone? Bueller?) will want to set the vtctld fqdn template flag; for example: discovery-consul-vtctld-fqdn-tmpl: "{{ "{{ .Hostname }}" }}.example.com"

@doeg doeg added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface release notes none labels Nov 4, 2021
@doeg doeg requested a review from ajm188 November 4, 2021 13:08
@doeg doeg requested a review from rohit-nayak-ps as a code owner November 4, 2021 13:08
@doeg doeg merged commit 133acbe into vitessio:main Nov 4, 2021
@doeg doeg deleted the sarabee-vtctlds branch November 4, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants