Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnlineDDL in v12: remove legacy code deprecated in earlier version #8971

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

shlomi-noach
Copy link
Contributor

Description

Context: #6926 (comment)
Followup to #8414

The commands vtctl OnlineDDL revert and vtctl VExec are removed in this PR. In v11 we already showed a deprecation warning to users, so we are now good for full removal.

VExec code will be subsequently completely removed (it's still being used internally by vtctl, and we will first change that internal behavior).

Checklist

  • Should this PR be backported? - yes, backporting to release 12
  • Tests were added or are not required
  • Documentation was added or is not required

@shlomi-noach
Copy link
Contributor Author

Backport to release-12.0: #8972

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach
Copy link
Contributor Author

Added release notes.

@shlomi-noach shlomi-noach merged commit d7f0034 into vitessio:main Oct 20, 2021
@shlomi-noach shlomi-noach deleted the v12-deprecate-onlineddl-vexec branch October 20, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants