Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] grpc streamexecute to set a target if tablet type is provided #8933

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Oct 5, 2021

Description

The go vitess driver uses StreamExecute to execute the stream * from <message_table>. In the grpc request if the target is not provided then it sets to <request.keyspace>@<request.tablet_type>

If the request.tablet_type is not set then the default is unknown tablet type.

The fix is to not set the the default target if tablet type is not provided.

Later in the code there is check to use default_tablet_type of vtgate to server the query if the tablet_type is not present in the target.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal harshit-gangal requested a review from systay October 5, 2021 12:49
@harshit-gangal harshit-gangal changed the base branch from main to release-12.0 October 5, 2021 12:49
@harshit-gangal harshit-gangal merged commit 562560b into vitessio:release-12.0 Oct 7, 2021
@harshit-gangal harshit-gangal deleted the bp-8926 branch October 7, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants