Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen4: derived table with aliased column names #8913

Merged
merged 13 commits into from
Oct 6, 2021

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Oct 1, 2021

Description

The changes introduced by #8884 allow us to parse derived tables' aliased column names, like: select t.i from (select id from user) t (i), here the id inner column becomes i on the outside.

This pull request adds supports for this kind of queries in Gen4.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Oct 1, 2021
@frouioui frouioui marked this pull request as ready for review October 6, 2021 07:55
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff

@frouioui frouioui force-pushed the gen4-derived-table-col branch from ad273ce to 18b966e Compare October 6, 2021 10:07
@systay systay merged commit 201db60 into vitessio:main Oct 6, 2021
@systay systay deleted the gen4-derived-table-col branch October 6, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants