[vtctl] run new commands as standalone binary #8893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the second half of #8881, and includes the following:
vtctldclient
out from aninternal/
subtree so thatgo/cmd/vtctl/
can import it.VtctldClientProtocol
to the root command structure ofvtctldclient
, to allow us to switch from grpc (normal mode) to local (invtctl
-standalone mode) -- see [vtctld] localvtctldclient #8882 for more detailsvtctl
binary:LegacyVtctldCommand
-- this prefix is there for future backwards compatibility. Existing scripts (which by definition have no prefix) invoking thevtctl
binary will continue to work without a prefix. In the next major version, we will make "no prefix" the same as the new commands, which gives users one version to switch over, and then we can drop the legacy stuff altogether.VtctldCommand
-- this prefix tells the vtctl binary to use the new commands. In the next major version, we will make "no prefix" the same as this, and in the version after we can drop the prefix stuff altogether, allowing users to phase their scripts overdemos
using new stuff
using new stuff, but with old flag syntax results in errors (as expected)
Related Issue(s)
Closes #8881
Checklist
Deployment Notes