Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix merging dba query as a subquery both in v3 and gen4 #8871

Merged
merged 2 commits into from
Sep 23, 2021
Merged

fix merging dba query as a subquery both in v3 and gen4 #8871

merged 2 commits into from
Sep 23, 2021

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Sep 23, 2021 •
edited
Loading

Description

SelectDBA queries were not being merged properly when occurring as subqueries. This PR fixes that both for V3 and Gen4 planners.

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required Added
  • Documentation was added or is not required Not required

Deployment Notes

harshit-gangal
harshit-gangal approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a case for dba query as derived table, if it does not exists

@GuptaManan100
Copy link
Member Author

Sure, I added it in the commit - 5887a34

@GuptaManan100 GuptaManan100 merged commit 8bfcf5c into vitessio:main Sep 23, 2021
@GuptaManan100 GuptaManan100 deleted the information-schema-bug branch September 23, 2021 13:01
@vmg vmg mentioned this pull request Sep 29, 2021
Closed
3 tasks
@Anders-PlanetScale Anders-PlanetScale mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flyway query on information schema stopped working
3 participants
@GuptaManan100 @harshit-gangal @frouioui