LegacySplitCloneWorker is no longer used in any code paths

[mattlord]

Signed-off-by: Matt Lord [email protected]

Description

Keeping things tidy...

Related Issue(s)

#4456

Checklist

• Should this PR be backported?
• Tests were added or are not required
• Documentation was added or is not required

[rafael]

Wow - end of an era! Excited to see this go. For completeness, we should not allow LegacySlitClone as an option from here.

Also, we should delete the resharding workflow entirely. But that could be a different PR.

[mattlord]

Wow - end of an era! Excited to see this go. For completeness, we should not allow LegacySlitClone as an option from here.

I tried to remove the remaining references in bfcfcb9

Let me know if you had something else in mind.

Also, we should delete the resharding workflow entirely. But that could be a different PR.

I'm actually not sure what you mean here and how it's related.

Thanks!

[mattlord]

Also, we should delete the resharding workflow entirely. But that could be a different PR.

@rafael Were you saying that we should remove the non-legacy SplitClone code too now that you should be using MoveTables instead in 6.0+? If so, then I think we probably should but can be done in a separate PR.

[rafael]

Wow - end of an era! Excited to see this go. For completeness, we should not allow LegacySlitClone as an option from here.

I tried to remove the remaining references in bfcfcb9

Let me know if you had something else in mind.

Perfect, this what I had in mind.

Also, we should delete the resharding workflow entirely. But that could be a different PR.

I'm actually not sure what you mean here and how it's related.

What I meant is that go/vt/workflow/resharding is all related to legacy code paths (pre vreplication and the new resharding methods). I'm thinking of this sequence:

• After removing LegacySplitClone, SplitClone could be removed as well.
• Then we can remove go/vt/workflow/resharding , reshardingworkflowgen and the related UI code in vtctld.

That could be in subsequent PR's, it would take this cleanup even further 🎉

Thanks!

[rafael]

LGTM