Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VtGate schema tracker to use provided user #8857

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Sep 21, 2021

Description

Schema tracking queries sent down to the vttablet will use the provided user in vtgate via flag schema_change_signal_user

Related Issue(s)

Checklist

Deployment Notes

Signed-off-by: Harshit Gangal <[email protected]>
…ys use the tracker context

Signed-off-by: Harshit Gangal <[email protected]>
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@harshit-gangal harshit-gangal merged commit 81fad37 into vitessio:main Sep 21, 2021
@harshit-gangal harshit-gangal deleted the schematracker-user branch September 21, 2021 13:12
@deepthi
Copy link
Member

deepthi commented Sep 22, 2021

Thank you for doing docs along with code. For anyone else watching, that is ideally how we should do any code change that requires a documentation addition or change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema Tracker Does Not Work with Strict ACL Checks
3 participants