-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slight improvement of the ACL error message #8805
Conversation
Signed-off-by: Florent Poinsard <[email protected]>
IMO, the more closely we mimic mysqld from the client's perspective the better -- so I'd vote for doing that here. So perhaps:
That way we also note the internal vitess area in parenthesis. |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a comment about retaining Groups
information in the error message.
Signed-off-by: Florent Poinsard <[email protected]>
Created #8854 to migrate this test to our self-hosted runners. |
Description
This pull request improves the ACL error message. The original error message was constructed as follows:
The first suggestion made by @deepthi, and pushed to this PR via d0db975, looks as follows:
Another suggestion which was to use MySQL's error message would look as follows:
This pull request is open to suggestions.
Checklist