Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added UNION testcases and auxilary code for running tests #8797

Merged
merged 6 commits into from
Sep 17, 2021
Merged

Added UNION testcases and auxilary code for running tests #8797

merged 6 commits into from
Sep 17, 2021

Conversation

ritwizsinha
Copy link
Contributor

@ritwizsinha ritwizsinha commented Sep 12, 2021 •
edited by GuptaManan100
Loading

Description

Added testcases for SELECT and union cases which were present in MYSQL

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required Yes
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@ritwizsinha
Added the select cases
cc1ff51 
Signed-off-by: ritwizsinha <[email protected]>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review September 16, 2021 09:38
GuptaManan100
GuptaManan100 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 😀

@ritwizsinha
Corrected linting
cc41b1f 
Signed-off-by: ritwizsinha <[email protected]>
@ritwizsinha
corrected imports order
d6085c6 
Signed-off-by: ritwizsinha <[email protected]>
frouioui
frouioui approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

go/vt/sqlparser/parse_test.go Outdated Show resolved Hide resolved
@ritwizsinha
Remove useless print
7cb20f5 
Signed-off-by: ritwizsinha <[email protected]>
@harshit-gangal harshit-gangal merged commit f46f665 into vitessio:main Sep 17, 2021
@ritwizsinha ritwizsinha mentioned this pull request Nov 22, 2021
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ritwizsinha @harshit-gangal @frouioui @GuptaManan100