Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing of MySQL Server Version flag #8791

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Sep 9, 2021

Description

We should only parse the MySQL Server Version flag if it is provided

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

go/vt/sqlparser/parser.go Outdated Show resolved Hide resolved
@systay systay merged commit 34973bb into vitessio:main Sep 10, 2021
@systay systay deleted the fix-server-version-parse branch September 10, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants