engine: allow retrying partial primitives #8727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicent Marti <[email protected]>
vmg
requested review from
deepthi,
harshit-gangal,
rohit-nayak-ps and
systay
as code owners
|
Ready for review 🍏 |
3 tasks
|
aaargh... this PR changes a ton of method names, but not the corresponding comments. Linting is angry every time I touch something in Fixing it, but we should think about this in future PRs |
|
Oops, sorry about that @systay, somehow the IDE didn't pick up the renames... And the linter in CI didn't either. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm splitting #8700 into its building blocks to make it easier to merge incrementally. This first chunk refactors the
engineprimitives so they can be eventually retried on failure. It's a pretty straightforward abstraction that introduces a helper inVCursor.cc @deepthi @harshit-gangal
Related Issue(s)
Checklist
Deployment Notes