-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GitHub Self Hosted Runner tests #8721
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! Looks very good to me. I left several suggestions and questions.
Can't wait to get rid of this flakiness, thanks a bunch @GuptaManan100 🚀
.github/workflows/cluster_endtoend_vreplication_basic_self_hosted.yml
Outdated
Show resolved
Hide resolved
By the way, @GuptaManan100, do you have an approximate idea of how flaky the tests are, (if they are), with this new configuration? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion, the rest LGTM.
We can merge once all feedback is addressed.
Yes, @frouioui The unit tests fail about once in 3 runs and vreplication tests fail once in 4 runs. It is less flakier than GitHub runners and faster too. The major motivation of this however, is to be able to look at the logs of the vtdataroot directory and fix the flakiness. With this change we will be able to easily move a test to the self-hosted runners if it is flaky and fix the issue |
Signed-off-by: Manan Gupta <[email protected]>
This is amazing |
Signed-off-by: Manan Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Adds infrastructure for shifting end to end tests to self-hosted runners. It also adds the documentation to how to use the self-hosted runners to find all the debug information.
Checklist