Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use AtomicInt32 instead of int to fix races #8696

Merged
merged 2 commits into from
Aug 27, 2021
Merged

tests: use AtomicInt32 instead of int to fix races #8696

merged 2 commits into from
Aug 27, 2021

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Aug 26, 2021

Description

Fix and re-enable tests disabled in #8692

Related Issue(s)

#8692

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@deepthi deepthi requested a review from frouioui August 26, 2021 22:10
frouioui
frouioui approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏🏻

Edit: Tests are still failing, we probably need the same technique for the error field in the Chunk test

@deepthi deepthi mentioned this pull request Aug 27, 2021
Closed
@deepthi deepthi merged commit 016756e into vitessio:main Aug 27, 2021
@deepthi deepthi deleted the ds-fix-vstream-test branch August 27, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
Component: Build/CI Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthi @frouioui