Initial implementation of partitions (Create statement) #8691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thirumalai-Shaktivel <[email protected]>
Thirumalai-Shaktivel
requested review from
GuptaManan100,
harshit-gangal and
systay
as code owners
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Thirumalai-Shaktivel <[email protected]>
Signed-off-by: Thirumalai-Shaktivel <[email protected]>
Signed-off-by: Thirumalai-Shaktivel <[email protected]>
Signed-off-by: Thirumalai-Shaktivel <[email protected]>
Signed-off-by: Thirumalai-Shaktivel <[email protected]>
|
Hi @GuptaManan100, this PR is ready |
Thirumalai-Shaktivel
changed the title
GuptaManan100
added
Component: Query Serving
Type: Enhancement
|
Anything else I need to fix?? If not, then this is good to go in... (I will send another PR for partition_definition and subpartition_definition) |
GuptaManan100
requested changes
Sep 1, 2021
|
Apart from these requested changes, everything looks good to me! Great work |
Signed-off-by: Thirumalai-Shaktivel <[email protected]>
Signed-off-by: Thirumalai-Shaktivel <[email protected]>
|
Hi @GuptaManan100, thanks for the review. I made all the changes as you suggested... |
GuptaManan100
approved these changes
Sep 7, 2021
|
The unit tests seem to be failing, could you take a look |
|
It seems all the tests are passing in my local system, I don't know where the issue is!! |
can you rebase from main and push it |
Signed-off-by: ritwizsinha <[email protected]>
Signed-off-by: ritwizsinha <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
|
Looks good to me! |
Signed-off-by: ritwizsinha <[email protected]>
GuptaManan100
approved these changes
Nov 17, 2021
Signed-off-by: Manan Gupta <[email protected]>
shlomi-noach
approved these changes
Nov 17, 2021
|
Thanks for reviewing and merging the code!! |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds grammar and AST structs and format funcs for partition operation subpartitions, partition/subpartition options.
Keywords related to partition statements are added. Sufficient partition cases were added to test the grammar change. Further partition grammar will be added in later PRs.
Related Issue(s)
Checklist
Deployment Notes